You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Hey @eecolella. Thanks for opening an issue! 😄
Can you share what solution you're using for nvm to work with fish?
Are you using a compatibility wrapper like https://github.com/FabioAntunes/fish-nvm, or have you set your $NVM_DIR manually?
In both the top and bottom, the version being used is v10.15.0? How is this a Spacefish issue, wouldn't this be an nvm issue? What are the wrappers above for, too? nvm is a bash script, https://github.com/creationix/nvm, why is a wrapper necessary?
The reason some nvm wrappers show the symbol and not others is because some don't use nvm directly and instead emulate nvm, like brigand/fast-nvm-fish, which is admittedly faster than actually using nvm, but doesn't alter NVM_BIN. This causes the version to not update since we cache the nvm version based on whether NVM_BIN has updated (what is happening in the screenshot).
What we need is a better fallback to node -v when we don't get a version value from nvm. At the moment we simply don't update it.
It might be worth creating an issue to go ahead and test several nvm wrappers to installation methods and write tests for them to ensure compatibility. 🤔
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug Report
Current Behavior
"nvm use" has no effect
Expected Behavior
"nvm use" should change node version
It is working with any theme, except spacefish
Environment
The text was updated successfully, but these errors were encountered: