Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: PACKAGES hack doesn't work on Windows #156

Open
kolyshkin opened this issue Sep 21, 2024 · 2 comments · May be fixed by #157
Open

ci: PACKAGES hack doesn't work on Windows #156

kolyshkin opened this issue Sep 21, 2024 · 2 comments · May be fixed by #157

Comments

@kolyshkin
Copy link
Collaborator

Apparently the hack introduced by #145 (using custom PACKAGES list for older Go versions) is not working and never worked on Windows.

Here is an example of a run which has the full list of PACKAGES on Windows:

https://github.com/moby/sys/actions/runs/10298746983/job/28504536200

You can see it works fine on other platforms (Linux and Mac OS X).
@kolyshkin
Copy link
Collaborator Author

@thaJeztah I'm thinking about a way to add a kludge to skip running a command if go version in package's go.mod is newer than that of go version.
@kolyshkin
Copy link
Collaborator Author

The alternative is to drop go 1.18 support 👯
@kolyshkin kolyshkin linked a pull request Sep 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@kolyshkin