Create Task
Maniphest T344955

Reduce Code Duplication between Evaluator Integration Tests and Benchmark Tests
Closed, ResolvedPublic
Actions

Description

Description

Some code related to running these tests is duplicated: asserting expected output and errors are correct, serializing the input, fetching the result, etc. This code can be factored out.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • less duplicated code between integration and benchmark tests

Completion checklist

Details

SubjectRepoBranchLines +/-
wikifunctions: Upgrade evaluators from 2023-11-29-143341 to 2024-01-18-182630operations/deployment-chartsmaster+2 -2
wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-09-190638operations/deployment-chartsmaster+1 -1
wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-18-182456operations/deployment-chartsmaster+1 -1
Update function-schemata sub-module to HEAD (ee9f315)mediawiki/extensions/WikiLambdamaster+1 -1
Customize query in gerrit
TitleReferenceAuthorSource BranchDest Branch
Update function-schemata sub-module to HEAD (1a02a7d)repos/abstract-wiki/wikifunctions/wikilambda-cli!25jforrestersync-function-schematamain
blubber: Stop defining 'benchmark-omnibus', no longer usedrepos/abstract-wiki/wikifunctions/function-evaluator!134jforresterT344955main
Update function-schemata sub-module to HEAD (496dc61)repos/abstract-wiki/wikifunctions/function-orchestrator!117apinesync-function-schematamain
Update function-schemata sub-module to HEAD (496dc61)repos/abstract-wiki/wikifunctions/function-evaluator!132apinesync-function-schematamain
Create inverse function to recover* functions.repos/abstract-wiki/wikifunctions/function-schemata!65apineapine-convert-request-formatmain
Customize query in GitLab

Related Objects

Event Timeline

cmassaro created this task.Aug 24 2023, 9:17 PM
cmassaro updated the task description. (Show Details)
cmassaro updated the task description. (Show Details)Aug 24 2023, 9:19 PM
Jdforrester-WMF triaged this task as Low priority.Sep 14 2023, 5:26 PM
Jdforrester-WMF moved this task from To triage to Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF mentioned this in T349557: Clean up the evaluator/executor interfaces once we've simplified into WASM everywhere.Oct 23 2023, 8:33 PM
CodeReviewBot added a comment.Dec 13 2023, 5:15 PM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/65

Create inverse function to recover* functions.

CodeReviewBot added a comment.Dec 13 2023, 9:06 PM

ecarg merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/65

Create inverse function to recover* functions.

CodeReviewBot added a project: Patch-For-Review.Jan 2 2024, 5:42 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/132

Update function-schemata sub-module to HEAD (496dc61)

CodeReviewBot added a comment.Jan 2 2024, 5:42 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/117

Update function-schemata sub-module to HEAD (496dc61)

gerritbot added a comment.Jan 2 2024, 5:43 PM

Change 987163 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (496dc61)

https://gerrit.wikimedia.org/r/987163

CodeReviewBot added a comment.Jan 2 2024, 8:11 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/117

Update function-schemata sub-module to HEAD (496dc61)

CodeReviewBot added a comment.Jan 2 2024, 8:11 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/132

Update function-schemata sub-module to HEAD (496dc61)

CodeReviewBot added a comment.Jan 3 2024, 7:44 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/134

blubber: Stop defining 'benchmark-omnibus', no longer used

CodeReviewBot added a comment.Jan 3 2024, 9:39 PM

ecarg merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/134

blubber: Stop defining 'benchmark-omnibus', no longer used

gerritbot added a comment.Jan 4 2024, 12:23 PM

Change 987163 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (ee9f315)

https://gerrit.wikimedia.org/r/987163

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ).Jan 4 2024, 1:00 PM
Jdforrester-WMF changed the task status from Open to In Progress.Jan 4 2024, 1:26 PM
Jdforrester-WMF moved this task from Backlog to In Progress on the Abstract Wikipedia team board.
Jdforrester-WMF assigned this task to ecarg.Jan 4 2024, 1:31 PM
Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Jan 8 2024, 9:03 PM
gerritbot added a comment.Jan 22 2024, 6:45 PM

Change 992225 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-18-182456

https://gerrit.wikimedia.org/r/992225

gerritbot added a comment.Jan 22 2024, 6:48 PM

Change 992227 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2023-11-29-143341 to 2024-01-18-182630

https://gerrit.wikimedia.org/r/992227

gerritbot added a comment.Jan 22 2024, 7:27 PM

Change 992225 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-18-182456

https://gerrit.wikimedia.org/r/992225

gerritbot added a comment.Jan 22 2024, 7:45 PM

Change 992229 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-09-190638

https://gerrit.wikimedia.org/r/992229

gerritbot added a comment.Jan 22 2024, 7:46 PM

Change 992229 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-09-190638

https://gerrit.wikimedia.org/r/992229

gerritbot added a comment.Jan 22 2024, 7:53 PM

Change 992227 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2023-11-29-143341 to 2024-01-18-182630

https://gerrit.wikimedia.org/r/992227

Jdforrester-WMF closed this task as Resolved.Jan 31 2024, 6:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits