Create Task
Maniphest T355457

WikibaseCirrusSearch test failure about increment on non-alphanumeric string (deprecated on php8.3)
Closed, ResolvedPublic
Actions

Description

Running tests with php8.3 shows the following failure:

1) Wikibase\Search\Elastic\Tests\Query\InLabelFeatureTest::testLimitFieldCount
Increment on non-alphanumeric string is deprecated

/workspace/src/extensions/WikibaseCirrusSearch/tests/phpunit/Query/InLabelFeatureTest.php:343
/workspace/src/extensions/WikibaseCirrusSearch/tests/phpunit/Query/InLabelFeatureTest.php:262

Details

SubjectRepoBranchLines +/-
Avoid PHP 8.3 deprecation warningmediawiki/extensions/WikibaseCirrusSearchmaster+4 -6
Customize query in gerrit

Event Timeline

Umherirrender created this task.Jan 19 2024, 10:17 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptJan 19 2024, 10:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Umherirrender moved this task from Backlog to Wikimedia production on the PHP 8.3 support board.Jan 19 2024, 10:28 PM
gerritbot added a comment.Jan 22 2024, 10:02 AM

Change 992091 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseCirrusSearch@master] Avoid PHP 8.3 deprecation warning

https://gerrit.wikimedia.org/r/992091

gerritbot added a project: Patch-For-Review.Jan 22 2024, 10:02 AM
Gehel moved this task from needs triage to Current work on the Discovery-Search board.Jan 22 2024, 1:34 PM
Gehel edited projects, added Discovery-Search (Current work); removed Discovery-Search.
Gehel moved this task from Incoming to Blocked/Waiting on the Discovery-Search (Current work) board.
Gehel moved this task from Blocked/Waiting to Needs review on the Discovery-Search (Current work) board.
gerritbot added a comment.Jan 22 2024, 2:21 PM

Change 992091 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Avoid PHP 8.3 deprecation warning

https://gerrit.wikimedia.org/r/992091

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2024, 2:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).Jan 22 2024, 3:00 PM
Gehel moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Jan 22 2024, 4:05 PM
Umherirrender closed this task as Resolved.Jan 22 2024, 5:20 PM
Umherirrender assigned this task to Lucas_Werkmeister_WMDE.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits