Hi!
User Details
- User Since
- Oct 25 2014, 1:53 AM (505 w, 1 d)
- Roles
- Administrator
- Availability
- Available
- IRC Nick
- Bawolff
- LDAP User
- Brian Wolff
- MediaWiki User
- Bawolff [ Global Accounts ]
Today
Yesterday
Wed, Jun 26
Sat, Jun 22
If I'm understanding correctly, you're saying that if a client accesses a static asset from Commons as part of (in this case) a Wikipedia page view
Sun, Jun 16
Sat, Jun 15
Fri, Jun 14
I think that is likely a good idea, but would like to defer to @Harej
Out of curiosity, are you intending to use this for something? Collabkit was never deployed, and the code is presumably quite bit rotted at this point.
The detection of third-party resources is still funky and I'd need to fine-tune the script but the initial version of the script generates the markdown table below.
With Wikimedia deployment being the end goal, I suppose putting it in core behind a feature flag would cause less friction than a whole new extension?
Thu, Jun 13
I would suggest making this an extension. I think this would be a very hard sell as a mw core feature.
Wed, Jun 12
Mon, Jun 10
As long as this isn't affecting availability and has no private information on it, I don't see what the benefit is of keeping this task secret.
Also, for reference, i tried to reproduce this, by installing 1.41.1 tarball, and doing wfLoadExtension( 'Auth_remoteuser' );$wgAuthRemoteuserUserName = "Everybody";, but i wasn't able to reproduce.
ES and FR crash.
EN, IT, RU work fine.
There are several other similar reports on Project:Support_desk, most of them saying it happens with no extensions just core mediawiki
Sun, Jun 9
Thu, Jun 6
I honestly had forgotten this even existed.
Sounds good to me
That said, perhaps its time to archive this extension unless someone else wants to take it up. It was never deployed and development work has largely stopped afaik.
it isn't clear that CVE-2021-43519 has been addressed at all.
Wed, Jun 5
3 is basically the approach i took in the QuickInstantCommons extension (if you are loading images over network all these problems get so much worse). It was really hacky but the result was very effective. However im not sure it would be acceptable in core.
Tue, Jun 4
The biggest known issue at this point is the jobs aren't restartable, but they will be restarted if a deploy happens in the middle of the job (which will cause a failure). But i agree that is best served by other tickets.
Which search feature are you referring to in this task?
Fri, May 31
May 31 2024
An alternate fix was merged (Still 7 chars, but use 7 even if ambiguous)
Well, I expect that bugs will a high priority are taken seriously.
May 30 2024
This should be at least priority "High"
May 22 2024
I guess i would check if the page table has any pages with a negative id. If not i would just delete the negative entries from page_props. Afterall it should be impossible to ever match the negative entries.
May 21 2024
@hinnk Can you try again (in async) mode, and see what happens?
Oh, maybe this is a dupe of T340882 and there is an alternate patch there
Looks like we determine file name by doing git rev-parse --short=7 HEAD if 7 characters is not unique it does the shortest unique string.
File name is FlaggedRevs-REL1_41-447bfbc2a.tar.gz but https://www.mediawiki.org/wiki/Special:ExtensionDistributor?extdistname=FlaggedRevs&extdistversion=REL1_41 points to https://extdist.wmflabs.org/dist/extensions/FlaggedRevs-REL1_41-447bfbc.tar.gz not https://extdist.wmflabs.org/dist/extensions/FlaggedRevs-REL1_41-447bfbc2a.tar.gz
May 19 2024
Hmm, i was going by caniuse saying that IE11 was the newest browser that didn't support it, which based on wikitech-l is soon to be grade X. I think thumbs not working in a grade X browser would be reasonable, but you raise a good point about the broader ecosystem.
I'm going to boldly re-open this for further discussion
May 17 2024
@TheDJ if its just that file being broken, I think it makes sense just to leave it the way it is, so I'm going to reclose this bug (but please reopen if you disagree)
May 16 2024
May 15 2024
I think IFD1 is for the embedded thumbnail (if present) and not the actual image. (ifd1 is irrelavent)
May 14 2024
I suspect it wont even be that much more increase on job queue since upload wizard is disabled on other wikis. This would entirely be about third party tools which is probably just a few people.
May 12 2024
May 11 2024
I ended up just reading the exiftool source code.
It would be useful to link to (or upload to this task) some example files with XMP [As a reminder, many devs do not actually have the ability to view deleted files on commons]. So far, I've noticed that image magick seems to diverge from the spec when creating webp files, so it would be good to have some examples from a variety of tools just to see what they do. (I guess i don't need this anymore, after looking through exiftool source code)
Why ICC? I don't think we would normally show that type of data on a file description page?
May 10 2024
I have no idea if anyone is still around who knows the history of why this is the way it is. @Sannita does the current upload wizard team have any thoughts or objections to changing this?
Ah, that would be the problem. Async uploads are disabled on english Wikipedia - https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/InitialiseSettings.php#L729-L735
Hmm, both of those errors on the server side indicate no async. So either something is wrong with the script or maybe enwiki somehow has async disabled
May 9 2024
Also broke the techblog link on mediawiki.org
May 8 2024
@hinnk How are you uploading these files? (Are you using UploadWizard, a specific user script, a bot program, something else?) I suspect this may be an issue with the tool being used to do uploads.
May 6 2024
I think there are two separate tickets here:
So recently i've been trying to collect information on cases where large uploads fail in order to try and fix the underlying issues. Did you attempt to upload this to commons in the normal way and it didn't work? If so, please let me know the details.
May 5 2024
May 3 2024
I think if we did deliver the wrong thumbsize, it only makes sense to deliver one larger then the requested size. Browsers will scale it client side, and its always better to downscale then upscale. The performance degredation is probably be not that bad - the larger thumbs would only be shown to first person to view the page. A small slowdown to image viewing for a single user seems not that bad, and better then never loading the image at all.
Possibly the value "auto" should also be treated as "100%"
May 2 2024
There are no interesting changes between 643fb6c (what mdwiki uses) and current master of TextExtracts. So either its a configuration difference or a change in a different component
May 1 2024
Are you reporting that this used to work but no longer does (In which case when was the last time it worked?), or has it always been this way and you are suggesting that the module should be changed to work as you describe?
the patch at https://pastebin.com/9wVWHEpa lgtm
Apr 29 2024
Maybe should just be limited just to executable files
Apr 21 2024
SVG is like HTML - there are dangerous parts but its not that big a deal. We allow <div> in wikitext but not <script>, we could do the same thing with svg potentially.
But if we don't find a replacement my assessment is that we will eventually end up in the same situation with timelines as we currently are with graphs.
Apr 19 2024
Maybe, but i would argue a new task would be better, when and if that happens.
my understanding is that this worked after retrying.
Seems like this is fixed! We just had File:OBR_Hafignnover_6-2024.webm (4.88 GB) successfully uploaded (req-id: c1a5aab7-6e6b-4ef5-b20d-f9ddb095577f ). The job took 5 minutes 20 seconds to complete, so went beyond the previous 202 second limit.
Apr 18 2024
Tagging for 1.39 release because there was a request on matrix to backport to REL1_39 (As in make mw core rel1_39 pull in a fixed version of library). I'll leave it to release managers if they want to do it.
per T358308 - one of the major causes of upload failure for medium-large files, is that during a deploy the job runners get killed. Making it retryable would fix that issue.
Can you try uploading again. The issue might be fixed now
Apr 17 2024
Yes, this is due to T358308. Until that is fixed, you can upload large (>3GB) files via https://commons.wikimedia.org/wiki/Help:Server_side_upload