New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial refactoring of `displayz` #3

Draft

shymega wants to merge 24 commits into michidk:main from shymega:refactor

shymega commented Jun 6, 2023 •

edited

Loading

Bump Cargo.lock and dependencies.
Use cfg_attr to expose platform-specific APIs in the platform module, then export with pub use.
Create initial common module for abstracting displays.
Make examples only run on Windows - pending refactoring of Windows backend.
Add lints.

Resolves #2.

shymega force-pushed the refactor branch from c98a2f1 to e7b914c Compare

June 6, 2023 18:06

michidk reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

michidk reviewed

View reviewed changes

src/common/mod.rs Outdated Show resolved Hide resolved

michidk reviewed

View reviewed changes

src/common/mod.rs Outdated Show resolved Hide resolved

michidk reviewed

View reviewed changes

src/common/mod.rs Outdated Show resolved Hide resolved

michidk reviewed

View reviewed changes

src/platforms/macos/mod.rs Outdated Show resolved Hide resolved

shymega commented

View reviewed changes

src/common/mod.rs Outdated Show resolved Hide resolved

shymega force-pushed the refactor branch from 192b70d to 6e42122 Compare

June 6, 2023 22:12

Author

shymega commented Jun 7, 2023

OK, some updates. I've added a note to Resolutions, and wrapped get_edid in an Option.

michidk assigned shymega

michidk added the enhancement label

shymega force-pushed the refactor branch 3 times, most recently from b772975 to b29f0cc Compare

June 21, 2023 15:40

shymega added 16 commits

June 21, 2023 16:41


          Initial refactoring of displayz

4e46aea

- Bump Cargo.lock and dependencies.
- Use `cfg_attr` to expose platform-specific APIs in the `platform`
  module, then export with `pub use`.
- Create initial `common` module for abstracting displays.
- Make examples only run on Windows - pending refactoring of Windows
  backend.
- Add lints.

Resolves michidk#2.


          Improve documentation on common module

cc27b10


          Fix #[cfg] attributes on Linux platform

484d20b


          Fix self-referencing import on Windows platform

71530f5


          Remove deny lint - as per review

4d48493


          Rename get_resolutions to be more clear

5fe124c


          Change Resolution/Position types to struct

76b96d7

(Also, change `usize` to `i32` to allow for negative Positions.
Resolution was changed for consistency)


          Add Linux Wayland/X11 feature flags and optional deps

2f7d397

This is in preparation for the Linux platform support.


          Clarify get_resolution method in DisplayOutput trait

73dc598


          Bump Cargo.lock

c6d2463


          Rename linux to unix to support BSDs/Linux

b5da993

We now use feature flags to control X11/Wayland exporting.


          Change Wayland dep target to unix target_family

d42f95f

This way we can support the BSDs, as well as Linux. I now know that
FreeBSD supports Wayland.


          Add initial struct for WaylandBackend

21aac60


          Add note to Resolutions type about future use

364433a


          Remove is_focused - move to platform-specific extensions

5129c31


          Wrap get_edid in an Option<T>

f3a7e5a


          Run cargo-fmt on codebase

3d1318a

shymega force-pushed the refactor branch from b29f0cc to 3d1318a Compare

June 21, 2023 15:41

shymega added 7 commits

June 23, 2023 23:12


          Revert "Add note to Resolutions type about future use"

657ce27

This reverts commit 364433a.

As per @michidk's review comment on PR michidk#3.


          Add Wayland protocols for Plasma/KDE

14871ba

This allows `displayz` to run on KDE, which uses a different set of
protocols to the usual `wlr` crate.


          refactor: Refactor types into structs, impl Debug/Display

6e37517

- Change `Resolutions` into tuple struct.
- Impl `Debug` & `Display` for `Position` and `Resolutions`.
- Use `Default` trait for default trait impl.


          refactor: Change Display type into dyn trait, for generics

7f1aa2f


          chore: Remove Windows CLI

e62b7dc


          chore: bump Cargo.lock

c81f8dc


          fix: Fix Derives in common/mod.rs

4d3a92f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment