Create Task
Maniphest T353451

Encapsulate ReferenceStackItem
Closed, ResolvedPublic
Actions

Description

The ReferenceStack class contains items with a heavy-weight abstraction, but currently written as generic arrays with string keys. This task is to convert the items into a first-class object, along the lines of P54438 . It's probably simplest to extract a pure data container in the first iteration, leaving the logic operating on the items still in ReferenceStack. Cite unit tests will also need to be adjusted.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT353227 [Epic] Cleanups in Cite Extension
 ResolvedawightT353451 Encapsulate ReferenceStackItem

Event Timeline

awight created this task.Dec 14 2023, 1:47 PM
awight claimed this task.Dec 19 2023, 12:48 PM
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2023-12-06 board.
gerritbot added a comment.Dec 19 2023, 1:14 PM

Change 984188 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] First-class internal data object for references

https://gerrit.wikimedia.org/r/984188

gerritbot added a project: Patch-For-Review.Dec 19 2023, 1:14 PM
gerritbot added a comment.Dec 21 2023, 8:43 AM

Change 984801 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Ref key is always an int

https://gerrit.wikimedia.org/r/984801

gerritbot added a comment.Dec 21 2023, 10:48 AM

Change 984801 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Ref sequence vs. key

https://gerrit.wikimedia.org/r/984801

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Dec 21 2023, 11:00 AM
gerritbot added a comment.Dec 21 2023, 8:01 PM

Change 984991 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Explicit parameter names for all test fixtures

https://gerrit.wikimedia.org/r/984991

gerritbot added a comment.Dec 21 2023, 8:17 PM

Change 984996 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] More explicit test fixtures: key and count

https://gerrit.wikimedia.org/r/984996

gerritbot added a comment.Dec 21 2023, 9:02 PM

Change 984991 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Explicit parameter names for all test fixtures

https://gerrit.wikimedia.org/r/984991

gerritbot added a comment.Dec 21 2023, 9:46 PM

Change 985018 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Fix fallback for count=null

https://gerrit.wikimedia.org/r/985018

gerritbot added a comment.Dec 22 2023, 9:00 AM

Change 985108 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] [WIP] Internal call stack uses structured refs

https://gerrit.wikimedia.org/r/985108

gerritbot added a comment.Dec 22 2023, 6:49 PM

Change 985332 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Render list-defined parent without a backlink

https://gerrit.wikimedia.org/r/985332

gerritbot added a comment.Dec 22 2023, 10:51 PM

Change 984188 abandoned by Awight:

[mediawiki/extensions/Cite@master] First-class internal data object for references

Reason:

Split into smaller patches.

https://gerrit.wikimedia.org/r/984188

gerritbot added a comment.Dec 22 2023, 11:01 PM

Change 985109 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Explicit test fixture field names

https://gerrit.wikimedia.org/r/985109

gerritbot added a comment.Dec 22 2023, 11:01 PM

Change 985046 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Rename internal variables

https://gerrit.wikimedia.org/r/985046

gerritbot added a comment.Dec 22 2023, 11:01 PM

Change 985336 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Copy group into refs

https://gerrit.wikimedia.org/r/985336

gerritbot added a comment.Dec 22 2023, 11:01 PM

Change 985337 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Remove test for a private method

https://gerrit.wikimedia.org/r/985337

gerritbot added a comment.Dec 22 2023, 11:01 PM

Change 985338 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Encapsulate ref object: limited to ReferenceStack

https://gerrit.wikimedia.org/r/985338

gerritbot added a comment.Dec 22 2023, 11:01 PM

Change 985339 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Encapsulate ref: pushRef returns an object

https://gerrit.wikimedia.org/r/985339

gerritbot added a comment.Dec 22 2023, 11:01 PM

Change 985340 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Encapsulate ref: groupRefs returned as objects

https://gerrit.wikimedia.org/r/985340

gerritbot added a comment.Dec 23 2023, 12:07 AM

Change 985109 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Explicit test fixture field names

https://gerrit.wikimedia.org/r/985109

thiemowmde added a project: WMDE-TechWish-Sprint-2024-01-04.Jan 4 2024, 12:54 PM
thiemowmde moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2024-01-04 board.
gerritbot added a comment.Jan 4 2024, 4:30 PM

Change 985337 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove test for a private method

https://gerrit.wikimedia.org/r/985337

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ); removed MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Jan 4 2024, 6:00 PM
gerritbot added a comment.Jan 5 2024, 11:40 AM

Change 985332 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Render list-defined parent without a backlink

https://gerrit.wikimedia.org/r/985332

gerritbot added a comment.Jan 5 2024, 11:50 AM

Change 985018 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Include more information in missing parent placeholder

https://gerrit.wikimedia.org/r/985018

gerritbot added a comment.Jan 5 2024, 11:53 AM

Change 984996 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] More explicit test fixtures: key and count

https://gerrit.wikimedia.org/r/984996

gerritbot added a comment.Jan 5 2024, 11:53 AM

Change 985336 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Store group in ref items

https://gerrit.wikimedia.org/r/985336

awight moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2024-01-04 board.Jan 8 2024, 11:34 AM
gerritbot added a comment.Jan 9 2024, 10:02 AM

Change 985338 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Encapsulate ref object: limited to ReferenceStack

https://gerrit.wikimedia.org/r/985338

gerritbot added a comment.Jan 9 2024, 10:06 AM

Change 985339 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Encapsulate ref: pushRef returns an object

https://gerrit.wikimedia.org/r/985339

gerritbot added a comment.Jan 9 2024, 10:13 AM

Change 985340 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Encapsulate ref: groupRefs returned as objects

https://gerrit.wikimedia.org/r/985340

gerritbot added a comment.Jan 9 2024, 10:20 AM

Change 985046 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Rename internal variables

https://gerrit.wikimedia.org/r/985046

awight removed awight as the assignee of this task.Jan 9 2024, 10:34 AM
awight moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2024-01-04 board.
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.14; 2024-01-16); removed MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ).Jan 9 2024, 11:00 AM
awight closed this task as Resolved.Jan 17 2024, 9:35 AM
awight claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits